From 0349229bac233a45b1294df178a6dfdd67dfa2aa Mon Sep 17 00:00:00 2001 From: "ashutosh.nehete" Date: Tue, 18 Nov 2025 17:45:31 +0530 Subject: [PATCH] added the logic only employee who created expense or payment requset able to submit it for review --- Marco.Pms.Services/Service/ExpensesService.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Marco.Pms.Services/Service/ExpensesService.cs b/Marco.Pms.Services/Service/ExpensesService.cs index 34603b2..d5aa451 100644 --- a/Marco.Pms.Services/Service/ExpensesService.cs +++ b/Marco.Pms.Services/Service/ExpensesService.cs @@ -1514,7 +1514,7 @@ namespace Marco.Pms.Services.Service // Special case: allow review status if creator is the logged-in user bool hasStatusPermission = Review == status.Id && loggedInEmployee.Id == paymentRequest.CreatedById; - if (!hasPermission && !hasStatusPermission) + if (!hasPermission || !hasStatusPermission) { continue; } @@ -3497,7 +3497,7 @@ namespace Marco.Pms.Services.Service var isRejected = model.StatusId == RejectedByApprover || model.StatusId == RejectedByReviewer; - if ((!isRejected) || (isRejected && (loggedInEmployeeId == model.CreatedById || hasManagePermission))) + if ((!isRejected) || (isRejected && loggedInEmployeeId == model.CreatedById)) { response.NextStatus = statusMapping.NextStatus.Where(ns => ns != null && ns.Id != Done).Select(ns => _mapper.Map(ns)).ToList(); }