From 03ee834505f512095f7027a7e46c2cd1a8d9dc72 Mon Sep 17 00:00:00 2001 From: "ashutosh.nehete" Date: Tue, 18 Nov 2025 18:01:17 +0530 Subject: [PATCH] Corrected the logic for next status in expense --- Marco.Pms.Services/Service/ExpensesService.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Marco.Pms.Services/Service/ExpensesService.cs b/Marco.Pms.Services/Service/ExpensesService.cs index d5aa451..7d07bf2 100644 --- a/Marco.Pms.Services/Service/ExpensesService.cs +++ b/Marco.Pms.Services/Service/ExpensesService.cs @@ -1512,9 +1512,13 @@ namespace Marco.Pms.Services.Service bool hasPermission = await permissionService.HasPermissionAny(permissionIds, loggedInEmployee.Id); // Special case: allow review status if creator is the logged-in user - bool hasStatusPermission = Review == status.Id && loggedInEmployee.Id == paymentRequest.CreatedById; - if (!hasPermission || !hasStatusPermission) + if (Review == status.Id && loggedInEmployee.Id != paymentRequest.CreatedById) + { + continue; + } + + if (!hasPermission) { continue; }