diff --git a/Marco.Pms.Services/Helpers/MasterHelper.cs b/Marco.Pms.Services/Helpers/MasterHelper.cs index 39bc86f..63d5478 100644 --- a/Marco.Pms.Services/Helpers/MasterHelper.cs +++ b/Marco.Pms.Services/Helpers/MasterHelper.cs @@ -60,7 +60,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error fetching services: {Message}", ex.Message); + _logger.LogError(ex, "Error fetching services"); return ApiResponse.ErrorResponse("An error occurred while fetching services", ex.Message, 500); } } @@ -113,7 +113,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error creating service: {Error}", ex.Message); + _logger.LogError(ex, "Error creating service"); return ApiResponse.ErrorResponse("Failed to create service", ex.Message, 500); } } @@ -165,7 +165,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error while updating service Id: {Id}. Exception: {Message}", id, ex.Message); + _logger.LogError(ex, "Error while updating service Id: {Id}.", id); return ApiResponse.ErrorResponse("An error occurred while updating the service", ex.Message, 500); } } @@ -213,7 +213,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Unexpected error occurred while deleting service {ServiceId} : {Error}", id, ex.Message); + _logger.LogError(ex, "Unexpected error occurred while deleting service {ServiceId}", id); return ApiResponse.ErrorResponse("Error deleting service", ex.Message, 500); } } @@ -242,7 +242,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error fetching activity groups: {Message}", ex.Message); + _logger.LogError(ex, "Error fetching activity groups"); return ApiResponse.ErrorResponse("An error occurred while fetching activity groups", ex.Message, 500); } } @@ -295,7 +295,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error creating activity group: {Error}", ex.Message); + _logger.LogError(ex, "Error creating activity group"); return ApiResponse.ErrorResponse("Failed to create activity group", ex.Message, 500); } } @@ -355,7 +355,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error while updating activity group Id: {Id}. Exception: {Message}", id, ex.Message); + _logger.LogError(ex, "Error while updating activity group Id: {Id}", id); return ApiResponse.ErrorResponse("An error occurred while updating the activity group", ex.Message, 500); } } @@ -403,7 +403,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Unexpected error occurred while deleting ActivityGroup {ActivityGroupId} : {Error}", id, ex.Message); + _logger.LogError(ex, "Unexpected error occurred while deleting ActivityGroup {ActivityGroupId}", id); return ApiResponse.ErrorResponse("Error deleting activity group", ex.Message, 500); } } @@ -460,7 +460,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error occurred in GetActivitiesMaster: {Error}", ex.Message); + _logger.LogError(ex, "Error occurred in GetActivitiesMaster"); return ApiResponse.ErrorResponse("Failed to fetch activity records", ex.Message, 500); } } @@ -526,7 +526,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Error occurred while creating activity: {Message}", ex.Message); + _logger.LogError(ex, "Error occurred while creating activity"); return ApiResponse.ErrorResponse("An error occurred while creating activity", ex.Message, 500); } } @@ -568,7 +568,7 @@ namespace Marco.Pms.Services.Helpers if (activity == null) { - _logger.LogError("Activity not found for ActivityId: {ActivityId}, TenantId: {TenantId}", id, tenantId); + _logger.LogWarning("Activity not found for ActivityId: {ActivityId}, TenantId: {TenantId}", id, tenantId); return ApiResponse.ErrorResponse("Activity not found", "Activity not found", 404); } @@ -634,7 +634,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Exception in UpdateActivity: {Message}", ex.Message); + _logger.LogError(ex, "Exception in UpdateActivity"); return ApiResponse.ErrorResponse("Error updating activity", ex.Message, 500); } } @@ -675,7 +675,7 @@ namespace Marco.Pms.Services.Helpers } catch (Exception ex) { - _logger.LogError("Unexpected error while deleting activity {ActivityId} : {Error}", id, ex.Message); + _logger.LogError(ex, "Unexpected error while deleting activity {ActivityId}", id); return ApiResponse.ErrorResponse("Error deleting activity", ex.Message, 500); } }