Changed the logic of validating
This commit is contained in:
parent
6f7fad1ae4
commit
540c3e75fd
@ -258,7 +258,7 @@ namespace Marco.Pms.Services.Controllers
|
|||||||
return StatusCode(403,
|
return StatusCode(403,
|
||||||
ApiResponse<object>.ErrorResponse("Access denied", "User does not have the required permissions for this action.", 403));
|
ApiResponse<object>.ErrorResponse("Access denied", "User does not have the required permissions for this action.", 403));
|
||||||
}
|
}
|
||||||
if ((hasModifyPermission || hasViewPermission) && id != loggedInEmployee.TenantId)
|
if (!hasManagePermission && (hasModifyPermission || hasViewPermission) && id != loggedInEmployee.TenantId)
|
||||||
{
|
{
|
||||||
_logger.LogWarning("Permission denied: User {EmployeeId} attempted to access tenant details of other tenant.", loggedInEmployee.Id);
|
_logger.LogWarning("Permission denied: User {EmployeeId} attempted to access tenant details of other tenant.", loggedInEmployee.Id);
|
||||||
return StatusCode(403,
|
return StatusCode(403,
|
||||||
@ -658,7 +658,7 @@ namespace Marco.Pms.Services.Controllers
|
|||||||
_logger.LogWarning("Access denied: User {EmployeeId} lacks required permissions for UpdateTenant on TenantId: {TenantId}.", loggedInEmployee.Id, id);
|
_logger.LogWarning("Access denied: User {EmployeeId} lacks required permissions for UpdateTenant on TenantId: {TenantId}.", loggedInEmployee.Id, id);
|
||||||
return StatusCode(403, ApiResponse<object>.ErrorResponse("Access denied", "User does not have the required permissions for this action.", 403));
|
return StatusCode(403, ApiResponse<object>.ErrorResponse("Access denied", "User does not have the required permissions for this action.", 403));
|
||||||
}
|
}
|
||||||
if (hasModifyPermission && id != loggedInEmployee.TenantId)
|
if (!hasManagePermission && hasModifyPermission && id != loggedInEmployee.TenantId)
|
||||||
{
|
{
|
||||||
_logger.LogWarning("Permission denied: User {EmployeeId} attempted to access tenant details of other tenant.", loggedInEmployee.Id);
|
_logger.LogWarning("Permission denied: User {EmployeeId} attempted to access tenant details of other tenant.", loggedInEmployee.Id);
|
||||||
return StatusCode(403,
|
return StatusCode(403,
|
||||||
|
Loading…
x
Reference in New Issue
Block a user