diff --git a/Marco.Pms.Services/Service/ExpensesService.cs b/Marco.Pms.Services/Service/ExpensesService.cs index b7d8370..951e961 100644 --- a/Marco.Pms.Services/Service/ExpensesService.cs +++ b/Marco.Pms.Services/Service/ExpensesService.cs @@ -689,6 +689,11 @@ namespace Marco.Pms.Services.Service public async Task> UpdateExpanseAsync(Guid id, UpdateExpensesDto model, Employee loggedInEmployee, Guid tenantId) { + if (id != model.Id) + { + _logger.LogWarning("Id provided by path parameter and Id from body not matches for employee {EmployeeId}", loggedInEmployee.Id); + return ApiResponse.ErrorResponse("Invalid Parameters", "Invalid Parameters", 400); + } var existingExpense = await _context.Expenses .Include(e => e.ExpensesType) .Include(e => e.Project) @@ -845,7 +850,7 @@ namespace Marco.Pms.Services.Service response.NextStatus = _mapper.Map>(nextPossibleStatuses); } - return ApiResponse.SuccessResponse(response); + return ApiResponse.SuccessResponse(response, "Expense Updated Successfully", 200); } catch (Exception ex) {