From a1db851eddc9b504163b6bc356ff728b13f18d70 Mon Sep 17 00:00:00 2001
From: "ashutosh.nehete" <ashutosh.nehete@marcoaiot.com>
Date: Thu, 24 Jul 2025 10:15:33 +0530
Subject: [PATCH] Added peoper return messages and validations in update
 expesnse API

---
 Marco.Pms.Services/Service/ExpensesService.cs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Marco.Pms.Services/Service/ExpensesService.cs b/Marco.Pms.Services/Service/ExpensesService.cs
index b7d8370..951e961 100644
--- a/Marco.Pms.Services/Service/ExpensesService.cs
+++ b/Marco.Pms.Services/Service/ExpensesService.cs
@@ -689,6 +689,11 @@ namespace Marco.Pms.Services.Service
 
         public async Task<ApiResponse<object>> UpdateExpanseAsync(Guid id, UpdateExpensesDto model, Employee loggedInEmployee, Guid tenantId)
         {
+            if (id != model.Id)
+            {
+                _logger.LogWarning("Id provided by path parameter and Id from body not matches for employee {EmployeeId}", loggedInEmployee.Id);
+                return ApiResponse<object>.ErrorResponse("Invalid Parameters", "Invalid Parameters", 400);
+            }
             var existingExpense = await _context.Expenses
                 .Include(e => e.ExpensesType)
                 .Include(e => e.Project)
@@ -845,7 +850,7 @@ namespace Marco.Pms.Services.Service
                     response.NextStatus = _mapper.Map<List<ExpensesStatusMasterVM>>(nextPossibleStatuses);
                 }
 
-                return ApiResponse<object>.SuccessResponse(response);
+                return ApiResponse<object>.SuccessResponse(response, "Expense Updated Successfully", 200);
             }
             catch (Exception ex)
             {