Added peoper return messages and validations in update expesnse API

This commit is contained in:
ashutosh.nehete 2025-07-24 10:15:33 +05:30
parent 8b5b0aed4c
commit a1db851edd

View File

@ -689,6 +689,11 @@ namespace Marco.Pms.Services.Service
public async Task<ApiResponse<object>> UpdateExpanseAsync(Guid id, UpdateExpensesDto model, Employee loggedInEmployee, Guid tenantId) public async Task<ApiResponse<object>> UpdateExpanseAsync(Guid id, UpdateExpensesDto model, Employee loggedInEmployee, Guid tenantId)
{ {
if (id != model.Id)
{
_logger.LogWarning("Id provided by path parameter and Id from body not matches for employee {EmployeeId}", loggedInEmployee.Id);
return ApiResponse<object>.ErrorResponse("Invalid Parameters", "Invalid Parameters", 400);
}
var existingExpense = await _context.Expenses var existingExpense = await _context.Expenses
.Include(e => e.ExpensesType) .Include(e => e.ExpensesType)
.Include(e => e.Project) .Include(e => e.Project)
@ -845,7 +850,7 @@ namespace Marco.Pms.Services.Service
response.NextStatus = _mapper.Map<List<ExpensesStatusMasterVM>>(nextPossibleStatuses); response.NextStatus = _mapper.Map<List<ExpensesStatusMasterVM>>(nextPossibleStatuses);
} }
return ApiResponse<object>.SuccessResponse(response); return ApiResponse<object>.SuccessResponse(response, "Expense Updated Successfully", 200);
} }
catch (Exception ex) catch (Exception ex)
{ {