From d9e0c2ee574aa923a3f37b2c2744b442b87ab099 Mon Sep 17 00:00:00 2001
From: "ashutosh.nehete" <ashutosh.nehete@marcoaiot.com>
Date: Thu, 18 Sep 2025 11:33:59 +0530
Subject: [PATCH] Resloved the issue #1125

---
 .../Controllers/EmployeeController.cs               | 13 +++++++------
 Marco.Pms.Services/Helpers/EmployeeHelper.cs        |  6 +++---
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/Marco.Pms.Services/Controllers/EmployeeController.cs b/Marco.Pms.Services/Controllers/EmployeeController.cs
index 2926db1..37a5527 100644
--- a/Marco.Pms.Services/Controllers/EmployeeController.cs
+++ b/Marco.Pms.Services/Controllers/EmployeeController.cs
@@ -148,12 +148,13 @@ namespace MarcoBMS.Services.Controllers
                     .Distinct()
                     .ToListAsync();
 
-                result = await _context.Employees
-                    .Include(fp => fp.JobRole)
-                    .Where(e => employeeIds.Contains(e.Id) && e.IsActive && e.TenantId == tenantId)
-                    .Select(e => e.ToEmployeeVMFromEmployee())
-                    .Distinct()
-                    .ToListAsync();
+                var employees = await _context.Employees
+                        .Include(fp => fp.JobRole)
+                        .Where(e => employeeIds.Contains(e.Id) && e.JobRole != null && e.IsActive && e.TenantId == tenantId)
+                        .Distinct()
+                        .ToListAsync();
+
+                result = employees.Select(e => e.ToEmployeeVMFromEmployee()).ToList();
 
                 _logger.LogInfo("Employee list fetched using limited access (active only).");
             }
diff --git a/Marco.Pms.Services/Helpers/EmployeeHelper.cs b/Marco.Pms.Services/Helpers/EmployeeHelper.cs
index edda815..6187628 100644
--- a/Marco.Pms.Services/Helpers/EmployeeHelper.cs
+++ b/Marco.Pms.Services/Helpers/EmployeeHelper.cs
@@ -85,12 +85,12 @@ namespace MarcoBMS.Services.Helpers
                     .Distinct()
                     .ToListAsync();
 
-                    result = await _context.Employees
+                    var employees = await _context.Employees
                         .Include(fp => fp.JobRole)
-                        .Where(e => employeeIds.Contains(e.Id) && e.IsActive && e.TenantId == tenantId)
-                        .Select(e => e.ToEmployeeVMFromEmployee())
+                        .Where(e => employeeIds.Contains(e.Id) && e.JobRole != null && e.IsActive && e.TenantId == tenantId)
                         .Distinct()
                         .ToListAsync();
+                    result = employees.Select(e => e.ToEmployeeVMFromEmployee()).ToList();
 
                 }
                 else if (ShowInActive)