From db8a811a6309bdf4e4e70c81b8b0b3ab1aa798aa Mon Sep 17 00:00:00 2001
From: Vaibhav Surve <vaibhav.surve@marcoaiot.com>
Date: Fri, 9 May 2025 10:13:00 +0530
Subject: [PATCH] Refactor AddEmployeeScreen for improved readability and
 consistency

---
 lib/view/dashboard/add_employee_screen.dart | 33 ++++++++-------------
 1 file changed, 12 insertions(+), 21 deletions(-)

diff --git a/lib/view/dashboard/add_employee_screen.dart b/lib/view/dashboard/add_employee_screen.dart
index e0829f4..d02dba8 100644
--- a/lib/view/dashboard/add_employee_screen.dart
+++ b/lib/view/dashboard/add_employee_screen.dart
@@ -24,12 +24,12 @@ class AddEmployeeScreen extends StatefulWidget {
 }
 
 class _AddEmployeeScreenState extends State<AddEmployeeScreen> with UIMixin {
-  AddEmployeeController controller = Get.put(AddEmployeeController());
+  final AddEmployeeController controller = Get.put(AddEmployeeController());
 
   @override
   Widget build(BuildContext context) {
     return Layout(
-      child: GetBuilder(
+      child: GetBuilder<AddEmployeeController>(
         init: controller,
         tag: 'add_employee_controller',
         builder: (controller) {
@@ -73,8 +73,7 @@ class _AddEmployeeScreenState extends State<AddEmployeeScreen> with UIMixin {
 
   Widget detail() {
     return Form(
-      key: controller
-          .basicValidator.formKey, // Ensure the key is correctly assigned
+      key: controller.basicValidator.formKey,
       child: MyCard.bordered(
         borderRadiusAll: 4,
         border: Border.all(color: Colors.grey.withOpacity(0.2)),
@@ -97,10 +96,8 @@ class _AddEmployeeScreenState extends State<AddEmployeeScreen> with UIMixin {
                 MyText.labelMedium("First Name"),
                 MySpacing.height(8),
                 TextFormField(
-                  validator:
-                      controller.basicValidator.getValidation('first_name'),
-                  controller:
-                      controller.basicValidator.getController('first_name'),
+                  validator: controller.basicValidator.getValidation('first_name'),
+                  controller: controller.basicValidator.getController('first_name'),
                   keyboardType: TextInputType.name,
                   decoration: InputDecoration(
                     hintText: "eg: Jhon",
@@ -117,10 +114,8 @@ class _AddEmployeeScreenState extends State<AddEmployeeScreen> with UIMixin {
                 MyText.labelMedium("Last Name"),
                 MySpacing.height(8),
                 TextFormField(
-                  validator:
-                      controller.basicValidator.getValidation('last_name'),
-                  controller:
-                      controller.basicValidator.getController('last_name'),
+                  validator: controller.basicValidator.getValidation('last_name'),
+                  controller: controller.basicValidator.getController('last_name'),
                   keyboardType: TextInputType.name,
                   decoration: InputDecoration(
                     hintText: "eg: Doe",
@@ -137,10 +132,8 @@ class _AddEmployeeScreenState extends State<AddEmployeeScreen> with UIMixin {
                 MyText.labelMedium("Phone Number"),
                 MySpacing.height(8),
                 TextFormField(
-                  validator:
-                      controller.basicValidator.getValidation('phone_number'),
-                  controller:
-                      controller.basicValidator.getController('phone_number'),
+                  validator: controller.basicValidator.getValidation('phone_number'),
+                  controller: controller.basicValidator.getController('phone_number'),
                   keyboardType: TextInputType.phone,
                   decoration: InputDecoration(
                     hintText: "eg: +91 9876543210",
@@ -171,8 +164,7 @@ class _AddEmployeeScreenState extends State<AddEmployeeScreen> with UIMixin {
                             return DropdownMenuItem<Gender>(
                               value: gender,
                               child: MyText.labelMedium(
-                                gender.name[0].toUpperCase() +
-                                    gender.name.substring(1),
+                                gender.name[0].toUpperCase() + gender.name.substring(1),
                               ),
                             );
                           }).toList(),
@@ -235,11 +227,10 @@ class _AddEmployeeScreenState extends State<AddEmployeeScreen> with UIMixin {
                   children: [
                     MyButton.text(
                       onPressed: () {
-                        Get.toNamed('/dashboard/employees');
+                        Get.back();
                       },
                       padding: MySpacing.xy(20, 16),
-                      splashColor:
-                          contentTheme.secondary.withValues(alpha: 0.1),
+                      splashColor: contentTheme.secondary.withValues(alpha: 0.1),
                       child: MyText.bodySmall('Cancel'),
                     ),
                     MySpacing.width(12),