Cancel button not closing All fields popup in masters #362

Merged
pramod.mahajan merged 2 commits from Kartik_Bug#979 into Issues_Aug_2W 2025-09-01 09:23:30 +00:00
15 changed files with 787 additions and 768 deletions

View File

@ -123,8 +123,7 @@ useEffect(() => {
<input <input
type="text" type="text"
{...register("activityName")} {...register("activityName")}
className={`form-control form-control-sm ${ className={`form-control form-control-sm ${errors.activityName ? "is-invalid" : ""
errors.activityName ? "is-invalid" : ""
}`} }`}
/> />
{errors.activityName && ( {errors.activityName && (
@ -137,8 +136,7 @@ useEffect(() => {
<input <input
type="text" type="text"
{...register("unitOfMeasurement")} {...register("unitOfMeasurement")}
className={`form-control form-control-sm ${ className={`form-control form-control-sm ${errors.unitOfMeasurement ? "is-invalid" : ""
errors.unitOfMeasurement ? "is-invalid" : ""
}`} }`}
/> />
{errors.unitOfMeasurement && ( {errors.unitOfMeasurement && (
@ -226,12 +224,13 @@ useEffect(() => {
{isLoading ? "Please Wait" : "Submit"} {isLoading ? "Please Wait" : "Submit"}
</button> </button>
<button <button
type="reset" type="button" // change to button
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
onClick={handleClose} onClick={handleClose}
> >
Cancel Cancel
</button> </button>
</div> </div>
</div> </div>
</form> </form>

View File

@ -97,13 +97,16 @@ useEffect(() => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="reset" type="button" // not reset
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={() => {
aria-label="Close" resetForm(); // clear inputs
onClose?.(); // close modal from parent
}}
> >
Cancel Cancel
</button> </button>
</div> </div>
</form> </form>

View File

@ -97,13 +97,16 @@ useEffect(() => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="reset" type="button" // not reset
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={() => {
aria-label="Close" resetForm(); // clear inputs
onClose?.(); // close modal from parent
}}
> >
Cancel Cancel
</button> </button>
</div> </div>
</form> </form>

View File

@ -123,13 +123,16 @@ const CreateJobRole = ({onClose}) => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="reset" type="button" // change from reset button
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={() => {
aria-label="Close" resetForm(); // optional: clears form
onClose?.(); // close modal via parent
}}
> >
Cancel Cancel
</button> </button>
</div> </div>
</form> </form>

View File

@ -233,13 +233,13 @@ const CreateRole = ({ modalType, onClose }) => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="reset" type="button"
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={onClose}
aria-label="Close"
> >
Cancel Cancel
</button> </button>
</div> </div>
)} )}
</form> </form>

View File

@ -77,9 +77,9 @@ useEffect(() => {
return (<> return (<>
<form className="row g-2" onSubmit={handleSubmit(onSubmit)}> <form className="row g-2" onSubmit={handleSubmit(onSubmit)}>
<div className="col-12 col-md-12"> {/* <div className="col-12 col-md-12">
<label className="fs-5 text-dark text-center d-flex align-items-center justify-content-center flex-wrap">Create Work Category</label> <label className="fs-5 text-dark text-center d-flex align-items-center justify-content-center flex-wrap">Create Work Category</label>
</div> </div> */}
<div className="col-12 col-md-12"> <div className="col-12 col-md-12">
<label className="form-label">Category Name</label> <label className="form-label">Category Name</label>
@ -113,10 +113,12 @@ useEffect(() => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="reset" type="button" // not reset
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={() => {
aria-label="Close" resetForm(); // clear inputs
onClose?.(); // close modal from parent
}}
> >
Cancel Cancel
</button> </button>

View File

@ -34,13 +34,15 @@ const DeleteMaster = ({ master, onClose }) => {
)} )}
</button> </button>
<button <button
type="reset" type="button" // not reset
className="btn btn-label-secondary" className="btn btn-label-secondary"
data-bs-dismiss="modal" onClick={() => {
aria-label="Close" onClose?.(); // properly close modal
}}
> >
Cancel Cancel
</button> </button>
</div> </div>
</div> </div>
); );

View File

@ -241,7 +241,7 @@ useEffect(() => {
{isLoading ? "Please Wait" : "Submit"} {isLoading ? "Please Wait" : "Submit"}
</button> </button>
<button <button
type="button" type="button" // change to button
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
onClick={onClose} onClick={onClose}
> >

View File

@ -116,10 +116,12 @@ useEffect(() => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="button" type="button" // not reset
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={() => {
aria-label="Close" resetForm(); // clear inputs
onClose?.(); // close modal from parent
}}
> >
Cancel Cancel
</button> </button>

View File

@ -116,10 +116,12 @@ useEffect(() => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="button" type="button" // not reset
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={() => {
aria-label="Close" resetForm(); // clear inputs
onClose?.(); // close modal from parent
}}
> >
Cancel Cancel
</button> </button>

View File

@ -134,13 +134,13 @@ const [descriptionLength, setDescriptionLength] = useState(data?.description?.le
<button <button
type="button" type="button"
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={onClose} // 👈 This will now close the popup
aria-label="Close"
> >
Cancel Cancel
</button> </button>
</div> </div>
</form> </form>
</> </>

View File

@ -280,11 +280,11 @@ const EditMaster = ({ master, onClose }) => {
<button <button
type="button" type="button"
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={onClose}
aria-label="Close"
> >
Cancel Cancel
</button> </button>
</div> </div>
</form> </form>

View File

@ -121,13 +121,13 @@ useEffect(() => {
{isLoading ? "Please Wait..." : "Submit"} {isLoading ? "Please Wait..." : "Submit"}
</button> </button>
<button <button
type="reset" type="button"
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={onClose}
aria-label="Close"
> >
Cancel Cancel
</button> </button>
</div> </div>
</form> </form>

View File

@ -79,14 +79,14 @@ const ManagePaymentMode = ({ data = null, onClose }) => {
{isPending || Updating ? "Please Wait..." : Updating ? "Update" : "Submit"} {isPending || Updating ? "Please Wait..." : Updating ? "Update" : "Submit"}
</button> </button>
<button <button
type="reset" type="button"
className="btn btn-sm btn-label-secondary" className="btn btn-sm btn-label-secondary"
data-bs-dismiss="modal" onClick={onClose} // call onClose here
aria-label="Close"
disabled={isPending || Updating} disabled={isPending || Updating}
> >
Cancel Cancel
</button> </button>
</div> </div>
</form> </form>
); );

View File

@ -122,13 +122,16 @@ const MasterPage = () => {
onChange={(e) => dispatch(changeMaster(e.target.value))} onChange={(e) => dispatch(changeMaster(e.target.value))}
name="DataTables_Table_0_length" name="DataTables_Table_0_length"
aria-controls="DataTables_Table_0" aria-controls="DataTables_Table_0"
className="form-select form-select-sm" className="form-select py-1 px-2"
style={{ fontSize: "0.875rem", height: "32px", width: "150px" }}
value={selectedMaster} value={selectedMaster}
> >
{isLoading && (<option value={null}>Loading...</option>)} {isLoading && <option value="">Loading...</option>}
{(!isLoading && data) && data?.map((item) => ( {!isLoading &&
data?.map((item) => (
<option key={item.id} value={item.name}>{item.name}</option> <option key={item.id} value={item.name}>
{item.name}
</option>
))} ))}
</select> </select>
</label> </label>