admin/marco.pms.web
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Adding Switch button in attendence component. #129

Merged
vikas.nale merged 3 commits from Kartik_Enhancement#274 into Issue_May_4W 2025-05-24 10:17:21 +00:00
Conversation 2 Commits 3 Files Changed 2 +100 -34
kartik.sharma commented 2025-05-22 11:11:00 +00:00
Collaborator
Copy Link

Adding Switch button in Attendence button when we click on this button
When the button is off all the data will show and when button is on then the checkin and checkout data is shown.

Adding Switch button in Attendence button when we click on this button When the button is off all the data will show and when button is on then the checkin and checkout data is shown.
kartik.sharma added 1 commit 2025-05-22 11:11:01 +00:00
vikas.nale commented 2025-05-23 05:24:37 +00:00
Collaborator
Copy Link

Looks like you have misinterpreted the requirement. Here we need to:

  1. Show toggle button for Logs tab only
  2. Button label should be "Show Pending Actions"
  3. When the toggle button is checked, it should only show the rows where the action is pending, like
  • Checkout is pending
  • Request to regularize is pending
  • Action is pending on the Regularization requested.

Currently, you are filtering actions completed. It should be inverse. Also, the label text should be changed as mentioned.

Please correct it and update the PR accordingly.

Looks like you have misinterpreted the requirement. Here we need to: 1. Show toggle button for Logs tab only 2. Button label should be "Show Pending Actions" 3. When the toggle button is checked, it should only show the rows where the action is pending, like - Checkout is pending - Request to regularize is pending - Action is pending on the Regularization requested. Currently, you are filtering actions completed. It should be inverse. Also, the label text should be changed as mentioned. Please correct it and update the PR accordingly.
kartik.sharma added 1 commit 2025-05-24 08:01:06 +00:00
kartik.sharma commented 2025-05-24 08:02:12 +00:00
Author
Collaborator
Copy Link

Correct in Switch on-off button in Attendance component.

Correct in Switch on-off button in Attendance component.
vikas.nale added 1 commit 2025-05-24 10:16:57 +00:00
vikas.nale merged commit 9d90f05f1c into Issue_May_4W 2025-05-24 10:17:21 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ashutosh.nehete kartik.sharma pramod.mahajan umesh.desai vaibhav.surve vikas.nale admin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/marco.pms.web#129
No description provided.
Delete Branch "Kartik_Enhancement#274"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?