admin/marco.pms.web
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

pramod_Bug#126ManageRole - Role selection UI bugs, empty state handling, and async refactor #53

Merged
vikas.nale merged 3 commits from pramod_Bug#126ManageRole into Issues_April_5W 2025-04-30 11:25:17 +00:00
Conversation 0 Commits 3 Files Changed 25 +220 -237
pramod.mahajan commented 2025-04-29 18:40:41 +00:00
Collaborator
Copy Link

I made the following improvements:

Prevented previously selected employee roles from displaying when switching between employees.

Roles now reset correctly in the form when a new employee is selected. Checkboxes reflect only the current employee’s assigned roles.

Removed the Zod validation that required at least one role. Users can now submit the form even when all roles are unchecked.

Replaced .then() chains with async/await for better readability and consistency in useEmployeeRoles.

Cleanup: Removed all console.log statements across related components.

I made the following improvements: Prevented previously selected employee roles from displaying when switching between employees. Roles now reset correctly in the form when a new employee is selected. Checkboxes reflect only the current employee’s assigned roles. Removed the Zod validation that required at least one role. Users can now submit the form even when all roles are unchecked. Replaced .then() chains with async/await for better readability and consistency in useEmployeeRoles. Cleanup: Removed all console.log statements across related components.
pramod.mahajan added 3 commits 2025-04-29 18:40:42 +00:00 
- Reset checkboxes when employee changes
- Allow submission when no roles are selected
- Fixed zod validation to support empty selections
vikas.nale merged commit 84f0e52f90 into Issues_April_5W 2025-04-30 11:25:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ashutosh.nehete kartik.sharma pramod.mahajan umesh.desai vaibhav.surve vikas.nale admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/marco.pms.web#53
No description provided.
Delete Branch "pramod_Bug#126ManageRole"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?