admin/marco.pms.web
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

made separate useActivityMaster hook that directly calling inside taskModal #59

Closed
pramod.mahajan wants to merge 2 commits from pramod_Bug#164 into Issues_May_1W
pull from: pramod_Bug#164
merge into: admin:Issues_May_1W
Conversation 2 Commits 2 Files Changed 2 +54 -20
pramod.mahajan commented 2025-05-03 13:56:16 +00:00
Collaborator
Copy Link

add separated activitymaster hook,correct cache check in useActivitiesMaster to prevent undefined activity data.

resolved issue with activity dropdown showing "Unnamed" in TaskModel

  • Issue was caused by useMaster() relying on global selectedMaster from Redux
  • When selectedMaster changed (e.g. to "Job Role"), activity data was replaced
  • Created new hook useActivitiesMaster() to fetch activities independently
  • useActivitiesMaster includes caching to avoid duplicate API calls
  • Replaced useMaster() with useActivitiesMaster() in TaskModel
  • Activity dropdown now always shows correct activity names
add separated activitymaster hook,correct cache check in useActivitiesMaster to prevent undefined activity data. resolved issue with activity dropdown showing "Unnamed" in TaskModel - Issue was caused by useMaster() relying on global selectedMaster from Redux - When selectedMaster changed (e.g. to "Job Role"), activity data was replaced - Created new hook useActivitiesMaster() to fetch activities independently - useActivitiesMaster includes caching to avoid duplicate API calls - Replaced useMaster() with useActivitiesMaster() in TaskModel - Activity dropdown now always shows correct activity names
pramod.mahajan added 1 commit 2025-05-03 13:56:17 +00:00
pramod.mahajan added 1 commit 2025-05-03 18:31:31 +00:00
pramod.mahajan commented 2025-05-03 18:32:31 +00:00
Author
Collaborator
Copy Link

Refactored TaskModel to remove useMaster() and dispatch(changeMaster), which were no longer needed after introducing the new useActivitiesMaster hook.

Refactored TaskModel to remove useMaster() and dispatch(changeMaster), which were no longer needed after introducing the new useActivitiesMaster hook.
vikas.nale commented 2025-05-05 12:04:36 +00:00
Collaborator
Copy Link

Added code directly

Added code directly
vikas.nale closed this pull request 2025-05-05 12:04:37 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ashutosh.nehete kartik.sharma pramod.mahajan umesh.desai vaibhav.surve vikas.nale admin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/marco.pms.web#59
No description provided.
Delete Branch "pramod_Bug#164"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?