admin/marco.pms.web
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

pramod_Bug-#203 -preserve selected employees when filtering by role in Daily Task Planning #91

Merged
vikas.nale merged 2 commits from pramod_Bug-#203 into Issue_May_2W 2025-05-10 10:41:25 +00:00
Conversation 0 Commits 2 Files Changed 1 +4 -3
pramod.mahajan commented 2025-05-09 16:55:16 +00:00
Collaborator
Copy Link

Issue
In the AssignRole ,Daily Task Planning module, when a user applied a filter by designation (role), the previously selected employees were unintentionally removed. This occurred because the handleRoleChange function was resetting the selected employees list with setSelectedEmployees([]).

Fixed
Removed the setSelectedEmployees([]) line from the handleRoleChange function to retain the selected employees even after changing the designation filter. Now, filtering by role no longer clears existing selections.

const handleRoleChange = (event) => {
  reset();
  // setSelectedEmployees([]); // This line caused selected employees to be removed
  setSelectedRole(event.target.value);
};
**Issue** In the AssignRole ,Daily Task Planning module, when a user applied a filter by designation (role), the previously selected employees were unintentionally removed. This occurred because the handleRoleChange function was resetting the selected employees list with setSelectedEmployees([]). **Fixed** Removed the setSelectedEmployees([]) line from the handleRoleChange function to retain the selected employees even after changing the designation filter. Now, filtering by role no longer clears existing selections. ``` const handleRoleChange = (event) => { reset(); // setSelectedEmployees([]); // This line caused selected employees to be removed setSelectedRole(event.target.value); }; ```
pramod.mahajan added 2 commits 2025-05-09 16:55:17 +00:00
vikas.nale merged commit 68475f4742 into Issue_May_2W 2025-05-10 10:41:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ashutosh.nehete kartik.sharma pramod.mahajan umesh.desai vaibhav.surve vikas.nale admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/marco.pms.web#91
No description provided.
Delete Branch "pramod_Bug-#203"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?